linux-kernel - Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5Ym4g9hmX3mT5+Eqm=KHKYd+s_PM4qdho2a8FkAZmhMHOV4g@mail.gmail.com>
Date: Fri, 4 Oct 2024 10:21:09 -0700
From: Sam Edwards <cfsworks@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Rafał Miłecki <rafal@...ecki.pl>, 
	William Zhang <william.zhang@...adcom.com>, Anand Gore <anand.gore@...adcom.com>, 
	Kursad Oney <kursad.oney@...adcom.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based
 on BCM4906

On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
> > On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
> >> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
> >> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
> >> marketing materials call this a "series," the EX3510-B1 appears to be a
> >> very minor revision of the EX3510-B0, with only changes that are
> >> transparent to software. As far as Linux is concerned, this "series"
> >> effectively represents a single model.
> >>
> >> Signed-off-by: Sam Edwards <CFSworks@...il.com>

Good day Krzysztof,

> >
> > Can you use the same email as for SoB?

I have sent patches to the LKML from a work email before, but I just
double-checked that I am using my personal email for everything here:

$ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed'
Author: Sam Edwards <CFSworks@...il.com>
    dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
    Signed-off-by: Sam Edwards <CFSworks@...il.com>
$ grep -E '^From|^Signed'
outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch
>From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001
From: Sam Edwards <CFSworks@...il.com>
Signed-off-by: Sam Edwards <CFSworks@...il.com>
$

> I meant, same for patch author and SoB. How is even possible to generate
> different data? You had to change it manually, which should make you
> wondering if this is correct.

Hey, on a meta level: I’d appreciate it if we could try to rule out
other possibilities before jumping to conclusions. Reading this made
me feel accused, and I think framing things collaboratively rather
than assigning blame will make it easier for all of us. How about we
start with what you’re seeing and work backwards?

Wishing you well,
Sam

>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >
> > Best regards,
> > Krzysztof
> >
>
> Best regards,
> Krzysztof
>