linux-kernel - Re: [PATCH v3] dt-bindings: display: mediatek: split: add subschema property constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32081590a38486a24211ed8a5981d3f1ce0f1188.camel@mediatek.com>
Date: Fri, 4 Oct 2024 02:59:50 +0000
From: Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
To: "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, Macpaul Lin (林智斌)
	<Macpaul.Lin@...iatek.com>, "airlied@...il.com" <airlied@...il.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: display: mediatek: split: add subschema
 property constraints

Hi,

This patch contains an incorrect compatible name; please excuse the
oversight and discard this patch.

Sincerely,
Moudy Ho

On Fri, 2024-10-04 at 10:24 +0800, Moudy Ho wrote:
> The display node in mt8195.dtsi was triggering a CHECK_DTBS error due
> to an excessively long 'clocks' property:
>   display@...06000: clocks: [[31, 14], [31, 43], [31, 44]] is too
> long
> 
> To resolve this issue, the constraints for 'clocks' and
> other properties within the subschemas will be reinforced.
> 
> Fixes: 739058a9c5c3 ("dt-bindings: display: mediatek: split: add
> compatible for MT8195")
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> 
> --
> This is based on [v2] dt-bindings: display: mediatek: split: add
> clocks count constraint for MT8195
> 
> Changes since v2:
>   - Revise the commit message.
>   - Enhance the descriptions of 'clocks'.
>   - Strengthen the conditions within the subschema.
> 
> Changes since v1:
>   - Adding functional descriptions and quantity restrictions.
> ---
>  .../display/mediatek/mediatek,split.yaml      | 24
> +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> index e4affc854f3d..0ffcd9d2b718 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> @@ -57,6 +57,9 @@ properties:
>    clocks:
>      items:
>        - description: SPLIT Clock
> +      - description: Used for interfacing with the HDMI RX signal
> source.
> +      - description: Paired with receiving HDMI RX metadata.
> +    minItems: 1
>  
>  required:
>    - compatible
> @@ -72,9 +75,30 @@ allOf:
>              const: mediatek,mt8195-mdp3-split
>  
>      then:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +
> +        power-domains:
> +          maxItems: 1
> +
>        required:
>          - mediatek,gce-client-reg
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt8173-mdp3-split
> +
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +
> +        power-domains:
> +          maxItems: 1
> +
>  additionalProperties: false
>  
>  examples: