linux-kernel - Re: [PATCH 1/1] fs/qnx6: Fix building with GCC 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hcjto6ziie4vlzw3baotdzh6km54nggzihs6htfxgii5bkuhx4@iopcp2buiawh>
Date: Sat, 5 Oct 2024 01:21:20 +0530
From: Brahmajit <brahmajit.xyz@...il.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: brauner@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] fs/qnx6: Fix building with GCC 15

On 04.10.2024 19:44, Al Viro wrote:
> LGTM, except that I'd probably make the commit message less warning-centric -
> something like
> ...
> would explain what was really going on - the point is not to make gcc STFU, it's
> to make the code more straightforward.  The warning is basically "it smells
> somewhat fishy around >here<, might be worth taking a look".  And yes, it turned
> out to be fishy; minimal "make it STFU" would be to strip those NULs from
> the initializers (i.e. just go for static char match_root[2][3] = {".", ".."}; -
> an array initializer is zero-padded if it's shorter than the array), but that
> wasn't the only, er, oddity in that code.

Thank you very much for the feedback, sending the patch with updates
commit shortly.

-- 
Regards,
listout