linux-kernel - Re: [PATCH] acl: Realign struct posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7E908DDE-0B55-4429-9F8D-A9719002E39A@linux.dev>
Date: Fri, 4 Oct 2024 23:12:09 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Jan Kara <jack@...e.cz>
Cc: Christian Brauner <brauner@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8
 bytes

On 4. Oct 2024, at 22:11, Thorsten Blum wrote:
> On 4. Oct 2024, at 15:37, Jan Kara wrote:
>> On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
>>> Reduce posix_acl's struct size by 8 bytes by realigning its members.
>>> 
>>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> 
>> Looks good. Feel free to add:
>> 
>> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> We should probably add:
> 
> Fixes: b0ab04a8ffd8 ("acl: Annotate struct posix_acl with __counted_by()")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202409260949.a1254989-oliver.sang@intel.com

Just realized Christian dropped b0ab04a8ffd8 (although it's still in
linux-next). I guess we don't need these tags then.

> as this patch is also a workaround for a Clang __bdos() bug (see the
> Closes: link for details).
> 
> Thanks,
> Thorsten