[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <92d5f299-b931-41a0-a337-001f4a0d9b90@quicinc.com>
Date: Fri, 4 Oct 2024 15:35:45 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
Bjorn Andersson
<andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Rob Clark
<robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Abhinav Kumar
<quic_abhinavk@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie
<airlied@...il.com>, Simona Vetter <simona@...ll.ch>
CC: <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH RFT 2/2] drm/msm/adreno: Setup SMMU aparture for
per-process page table
On 10/2/2024 8:01 PM, Bjorn Andersson wrote:
> Support for per-process page tables requires the SMMU aparture to be
> setup such that the GPU can make updates with the SMMU. On some targets
> this is done statically in firmware, on others it's expected to be
> requested in runtime by the driver, through a SCM call.
>
> One place where configuration is expected to be done dynamically is the
> QCS6490 rb3gen2.
>
> The downstream driver does this unconditioanlly on any A6xx and newer,
> so follow suite and make the call.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@....qualcomm.com>
Hi Bjorn,
Tested-by: Jessica Zhang <quic_jesszhan@...cinc.com> # Trogdor (sc7180)
Thanks,
Jessica Zhang
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 465a4cd14a43..5b06f7a04fe6 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -572,8 +572,18 @@ struct drm_gem_object *adreno_fw_create_bo(struct msm_gpu *gpu,
>
> int adreno_hw_init(struct msm_gpu *gpu)
> {
> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> + int ret;
> +
> VERB("%s", gpu->name);
>
> + if (adreno_gpu->info->family >= ADRENO_6XX_GEN1) {
> + /* We currently always use context bank 0, so hard code this */
> + ret = qcom_scm_set_gpu_smmu_aperture(0);
> + if (ret)
> + DRM_DEV_ERROR(gpu->dev->dev, "unable to set SMMU aperture: %d\n", ret);
> + }
> +
> for (int i = 0; i < gpu->nr_rings; i++) {
> struct msm_ringbuffer *ring = gpu->rb[i];
>
>
> --
> 2.45.2
>
>
Powered by blists - more mailing lists