linux-kernel - Re: [PATCH v1 1/8] tracing: Declare system call tracepoints with TRACE_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecd8a2fe-22f4-4340-a80b-5bf7ccd74815@efficios.com>
Date: Thu, 3 Oct 2024 20:15:25 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 Peter Zijlstra <peterz@...radead.org>, Alexei Starovoitov <ast@...nel.org>,
 Yonghong Song <yhs@...com>, "Paul E . McKenney" <paulmck@...nel.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Namhyung Kim <namhyung@...nel.org>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>, bpf@...r.kernel.org,
 Joel Fernandes <joel@...lfernandes.org>, linux-trace-kernel@...r.kernel.org,
 Michael Jeanson <mjeanson@...icios.com>
Subject: Re: [PATCH v1 1/8] tracing: Declare system call tracepoints with
 TRACE_EVENT_SYSCALL

On 2024-10-03 23:32, Steven Rostedt wrote:
> On Thu,  3 Oct 2024 11:16:31 -0400
> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> 
>> @@ -283,8 +290,13 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
>>   				  "RCU not watching for tracepoint");	\
>>   		}							\
>>   	}								\
>> -	__DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args),		\
>> -			    PARAMS(cond))				\
>> +	static inline void trace_##name##_rcuidle(proto)		\
>> +	{								\
>> +		if (static_key_false(&__tracepoint_##name.key))		\
>> +			__DO_TRACE(name,				\
>> +				TP_ARGS(args),				\
>> +				TP_CONDITION(cond), 1);			\
>> +	}								\
>>   	static inline int						\
>>   	register_trace_##name(void (*probe)(data_proto), void *data)	\
>>   	{								\
> 
> Looking at this part of your change, I realized it's time to nuke the
> rcuidle() variant.
> 
> Feel free to rebase on top of this patch:
> 
>    https://lore.kernel.org/all/20241003173051.6b178bb3@gandalf.local.home/
> 

I will. But you realize that you could have done all this SRCU and
rcuidle nuking on top of my own series rather than pull the rug
under my feet and require me to re-do this series again ?

Grumpily,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com