linux-kernel - RE: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OS8PR06MB75411555216E89213DA0933EF2722@OS8PR06MB7541.apcprd06.prod.outlook.com>
Date: Fri, 4 Oct 2024 06:58:27 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andi Shyti
	<andi.shyti@...nel.org>
CC: "brendan.higgins@...ux.dev" <brendan.higgins@...ux.dev>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>, "joel@....id.au"
	<joel@....id.au>, "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver

> Subject: Re: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver
> 
> On Thu, Oct 03, 2024 at 02:20:54PM +0200, Andi Shyti wrote:
> > On Thu, Oct 03, 2024 at 01:15:50PM GMT, Andy Shevchenko wrote:
> > > On Thu, Oct 03, 2024 at 03:41:57AM +0000, Ryan Chen wrote:
> > > > > On Wed, Oct 02, 2024 at 03:02:10PM +0800, Ryan Chen wrote:
> 
> ...
> 
> > > > > Is it possible to switch to new terminology wherever it's possible?
> > > > > I.e. master --> controller, slave --> target. See, for example,
> > > > > f872d28500bd
> > > > > ("i2c: uniphier-f: reword according to newest specification").
> > > > >
> > > > Just for cover latter? Or I should modify for each patches commit
> message?
> > > > Or entire i2c driver statement need switch to target?
> > >
> > > I believe everywhere, where it applies: driver code, comments,
> > > documentation, commit messages...
> >
> > If the datasheet refers to a register, state, or any other hardware
> > property as master/slave, we should retain the master/slave
> > terminology. Otherwise, we should follow the i2c and smbus
> > specifications and use controller/target.
> 
> Indeed, makes sense. Thank you, Andi, for the corrections!
> 
Thanks, I will modify with controller/target in sw driver parts. Keep the hw datasheet statement. 
> --
> With Best Regards,
> Andy Shevchenko
>