linux-kernel - Re: [PATCH V5 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61299c8f-4603-4f9f-9aee-8e4e51945d44@quicinc.com>
Date: Fri, 4 Oct 2024 13:31:59 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Devi Priya
	<quic_devipriy@...cinc.com>, <andersson@...nel.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <p.zabel@...gutronix.de>,
        <richardcochran@...il.com>, <geert+renesas@...der.be>,
        <dmitry.baryshkov@...aro.org>, <neil.armstrong@...aro.org>,
        <arnd@...db.de>, <m.szyprowski@...sung.com>, <nfraprado@...labora.com>,
        <u-kumar1@...com>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <netdev@...r.kernel.org>, <konradybcio@...nel.org>
Subject: Re: [PATCH V5 5/7] clk: qcom: Add NSS clock Controller driver for
 IPQ9574



On 6/26/2024 9:09 PM, Konrad Dybcio wrote:
> On 26.06.2024 4:33 PM, Devi Priya wrote:
>> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
>> devices.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> Tested-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
>> ---
> 
> [...]
> 
>> +	struct regmap *regmap;
>> +	struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
>> +	struct clk *nsscc_clk;
>> +	struct device_node *np = (&pdev->dev)->of_node;
>> +	int ret;
>> +
>> +	nsscc_clk = of_clk_get(np, 11);
>> +	if (IS_ERR(nsscc_clk))
>> +		return PTR_ERR(nsscc_clk);
>> +
>> +	ret = clk_prepare_enable(nsscc_clk);
>> +	if (ret)
>> +		clk_disable_unprepare(nsscc_clk);
> 
> No changes to be seen..
> 

Hi Konrad,

Sorry for the delayed response.

The ethernet node will subscribe to GCC_NSSCC_CLK and enable it.
Hence, it need not be obtained and setup here. Will drop this.

Thanks & Regards,
Manikanta.

> Konrad