linux-kernel - Re: [PATCH 6.6 000/533] 6.6.54-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024100410-daughter-pruning-e2a6@gregkh>
Date: Fri, 4 Oct 2024 14:37:35 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Wang Yugui <wangyugui@...-tech.com>
Cc: stable@...r.kernel.org, patches@...ts.linux.dev,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
	patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
	jonathanh@...dia.com, f.fainelli@...il.com,
	sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
	conor@...nel.org, allen.lkml@...il.com, broonie@...nel.org
Subject: Re: [PATCH 6.6 000/533] 6.6.54-rc2 review

On Fri, Oct 04, 2024 at 06:57:07PM +0800, Wang Yugui wrote:
> Hi,
> 
> > On Fri, Oct 04, 2024 at 07:17:24AM +0800, Wang Yugui wrote:
> > > Hi,
> > > 
> > > > This is the start of the stable review cycle for the 6.6.54 release.
> > > > There are 533 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sat, 05 Oct 2024 10:30:30 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.54-rc2.gz
> > > > or in the git tree and branch at:
> > > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > > > and the diffstat can be found below.
> > > 
> > > A new waring is report by 'make bzImage' in 6.6.54-rc2, 
> > > but that is not reported in 6.6.53 and 6.12-rc1.
> > > 
> > > arch/x86/tools/insn_decoder_test: warning: Found an x86 instruction decoder bug, please report this.
> > > arch/x86/tools/insn_decoder_test: warning: ffffffff8103c4d5:    c4 03 81 48 cf e9       vpermil2ps $0x9,%xmm15,%xmm14,%xmm15,%xmm9
> > > arch/x86/tools/insn_decoder_test: warning: objdump says 6 bytes, but insn_get_length() says 0
> > > arch/x86/tools/insn_decoder_test: warning: Decoded and checked 6968668 instructions with 1 failures
> > > 
> > > the root cause is yet not clear.
> > 
> > I've been seeing this locally for all 6.6.y releases, so for me it isn't
> > new, and I can't seem to track down the root cause.  As it's just now
> > showing up for you, can you do a 'git bisect' to find out the issue?
> 
> 'git bisect'  show that the root cause is
> 	x86/entry: Remove unwanted instrumentation in common_interrupt()
> 
> after reverting this patch to 6.6.54-rc2, this warning does not happen.
> 
> gcc --version:
> gcc (GCC) 8.3.1 20190311 (Red Hat 8.3.1-3)

Wow that's an old version of gcc.  can't you use anything more modern?

Anyway, that patch looks sane, it's just moving stuff around, it's not
making any new code anywhere from what I can see so perhaps the decoder
test just needs to be updated with a patch we have missed from newer
releases?  I'll dig into that after this release is out unless someone
beats me to it...

thanks,

greg k-h