[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <741ce24b-646d-4ae0-8c0e-72dd9b4f81f7@oracle.com>
Date: Fri, 4 Oct 2024 13:45:22 +0100
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: axboe@...nel.dk, brauner@...nel.org, djwong@...nel.org,
viro@...iv.linux.org.uk, jack@...e.cz, dchinner@...hat.com,
cem@...nel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
linux-fsdevel@...r.kernel.org, hare@...e.de,
martin.petersen@...cle.com, catherine.hoang@...cle.com,
mcgrof@...nel.org, ritesh.list@...il.com, ojaswin@...ux.ibm.com
Subject: Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in
generic_atomic_write_valid()
On 04/10/2024 13:34, Christoph Hellwig wrote:
> On Fri, Oct 04, 2024 at 09:22:49AM +0000, John Garry wrote:
>> Currently FMODE_CAN_ATOMIC_WRITE is set if the bdev can atomic write and
>> the file is open for direct IO. This does not work if the file is not
>> opened for direct IO, yet fcntl(O_DIRECT) is used on the fd later.
>
> This sound like a bug fix for 6.12-rc?
The worse that can happen is that a RWF_ATOMIC would be rejected for
scenario described (with using fcntl(O_DIRECT)).
But you are right, it is a fix really. I would need to add patch 1/8 as
well, as it provides the iocb pointer needed.
I'll mark them both as fixes then.
>
> The fix looks good to me:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
cheers
>
Powered by blists - more mailing lists