linux-kernel - Re: [PATCH] sign-file: Add -D "digest mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410042115.WT7VlS8U-lkp@intel.com>
Date: Fri, 4 Oct 2024 21:30:05 +0800
From: kernel test robot <lkp@...el.com>
To: Fam Zheng <fam.zheng@...edance.com>, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, fam@...hon.net,
	David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>, fam.zheng@...edance.com
Subject: Re: [PATCH] sign-file: Add -D "digest mode"

Hi Fam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.12-rc1 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Fam-Zheng/sign-file-Add-D-digest-mode/20241002-215025
base:   linus/master
patch link:    https://lore.kernel.org/r/20241002133837.1030094-1-fam.zheng%40bytedance.com
patch subject: [PATCH] sign-file: Add -D "digest mode"
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241004/202410042115.WT7VlS8U-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410042115.WT7VlS8U-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410042115.WT7VlS8U-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from scripts/sign-file.c:40:
   scripts/sign-file.c: In function 'main':
>> scripts/sign-file.c:357:29: warning: implicit declaration of function 'CMS_final_digest' [-Wimplicit-function-declaration]
     357 |                         ERR(CMS_final_digest(cms, digest_bin, digest_len, NULL, CMS_NOCERTS | CMS_BINARY) != 1,
         |                             ^~~~~~~~~~~~~~~~
   scripts/ssl-common.h:27:32: note: in definition of macro 'ERR'
      27 |                 bool __cond = (cond);                   \
         |                                ^~~~
--
   In file included from scripts/sign-file.c:40:
   scripts/sign-file.c: In function 'main':
>> scripts/sign-file.c:357:29: warning: implicit declaration of function 'CMS_final_digest' [-Wimplicit-function-declaration]
     357 |                         ERR(CMS_final_digest(cms, digest_bin, digest_len, NULL, CMS_NOCERTS | CMS_BINARY) != 1,
         |                             ^~~~~~~~~~~~~~~~
   scripts/ssl-common.h:27:32: note: in definition of macro 'ERR'
      27 |                 bool __cond = (cond);                   \
         |                                ^~~~


vim +/CMS_final_digest +357 scripts/sign-file.c

   329	
   330		if (!raw_sig) {
   331			/* Read the private key and the X.509 cert the PKCS#7 message
   332			 * will point to.
   333			 */
   334			private_key = read_private_key(private_key_name);
   335			x509 = read_x509(x509_name);
   336	
   337			/* Digest the module data. */
   338			OpenSSL_add_all_digests();
   339			drain_openssl_errors(__LINE__, 0);
   340			digest_algo = EVP_get_digestbyname(hash_algo);
   341			ERR(!digest_algo, "EVP_get_digestbyname");
   342	
   343	#ifndef USE_PKCS7
   344			/* Load the signature message from the digest buffer. */
   345			cms = CMS_sign(NULL, NULL, NULL, NULL,
   346				       CMS_NOCERTS | CMS_PARTIAL | CMS_BINARY |
   347				       CMS_DETACHED | CMS_STREAM);
   348			ERR(!cms, "CMS_sign");
   349	
   350			ERR(!CMS_add1_signer(cms, x509, private_key, digest_algo,
   351					     CMS_NOCERTS | CMS_BINARY |
   352					     CMS_NOSMIMECAP | use_keyid |
   353					     (digest_mode ? CMS_KEY_PARAM : 0) |
   354					     use_signed_attrs),
   355			    "CMS_add1_signer");
   356			if (digest_mode)
 > 357				ERR(CMS_final_digest(cms, digest_bin, digest_len, NULL, CMS_NOCERTS | CMS_BINARY) != 1,
   358				    "CMS_final_digest");
   359			else
   360				ERR(CMS_final(cms, bm, NULL, CMS_NOCERTS | CMS_BINARY) != 1,
   361				    "CMS_final");
   362	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki