linux-kernel - Re: [PATCH] acl: Realign struct posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241004133716.enkqnmosn42oagos@quack3>
Date: Fri, 4 Oct 2024 15:37:16 +0200
From: Jan Kara <jack@...e.cz>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8
 bytes

On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
> Reduce posix_acl's struct size by 8 bytes by realigning its members.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/posix_acl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 83b2c5fba1d9..e2d47eb1a7f3 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -28,8 +28,8 @@ struct posix_acl_entry {
>  
>  struct posix_acl {
>  	refcount_t		a_refcount;
> -	struct rcu_head		a_rcu;
>  	unsigned int		a_count;
> +	struct rcu_head		a_rcu;
>  	struct posix_acl_entry	a_entries[] __counted_by(a_count);
>  };
>  
> -- 
> 2.46.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR