linux-kernel - Re: [PATCHv3 1/2] platform/x86: dell-sysman: remove match on www.dell.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb6c6347-e665-8057-f825-1acfec682ea3@linux.intel.com>
Date: Fri, 4 Oct 2024 16:45:01 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Crag Wang <crag0715@...il.com>
cc: mario.limonciello@....com, Prasanth Ksr <prasanth.ksr@...l.com>, 
    Hans de Goede <hdegoede@...hat.com>, crag.wang@...l.com, 
    Crag Wang <crag_wang@...l.com>, Dell.Client.Kernel@...l.com, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 1/2] platform/x86: dell-sysman: remove match on
 www.dell.com

On Fri, 4 Oct 2024, Crag Wang wrote:

> The URL is dynamic and may change according to the OEM. It was mainly used
> for old systems that do not have "Dell System" in the OEM String.
> 
> Signed-off-by: Crag Wang <crag_wang@...l.com>
> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 9def7983d7d6..c05474f1ed70 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -520,8 +520,7 @@ static int __init sysman_init(void)
>  {
>  	int ret = 0;
>  
> -	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
> -	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
> +	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL)) {

I suggested making the changes in the opposite order, that was to 
faciliate easy revert of the URL patch if needed which is not the case if
things are changed in this order.

-- 
 i.