linux-kernel - Re: [PATCH] usb: usbtmc: initialize memory written to device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024100449-guiding-pesky-566a@gregkh>
Date: Fri, 4 Oct 2024 15:56:04 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Alexander Potapenko <glider@...gle.com>
Cc: bemenboshra2001@...il.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, syzkaller-bugs@...glegroups.com,
	nogikh@...gle.com, dvyukov@...gle.com, elver@...gle.com,
	pimyn@...gle.com,
	syzbot+8f282cce71948071c335@...kaller.appspotmail.com
Subject: Re: [PATCH] usb: usbtmc: initialize memory written to device

On Fri, Oct 04, 2024 at 03:41:22PM +0200, Alexander Potapenko wrote:
> On Fri, Oct 4, 2024 at 2:57 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Fri, Oct 04, 2024 at 12:33:13PM +0000, Pimyn@....codeaurora.org wrote:
> 
> Just curious, what's up with this @web.codeaurora.org address? It
> wasn't in the original patch, where did it come from? :)

You tell me, look at the original patch, it's in the email...

> > > Avoid kernel-usb-infoleak by initializing all memory written to device.
> > > The buffer length uses 32bit alignment which might cause some buffer
> > > data to be read without any initialization.
> > >
> > > Reported-by: syzbot+8f282cce71948071c335@...kaller.appspotmail.com
> > > Closes: https://lore.kernel.org/all/0000000000006f6622061eb52dba@google.com/T/
> > > Signed-off-by: Pimyn Girgis <bemenboshra2001@...il.com> (Google)
> > > ---
> > >  drivers/usb/class/usbtmc.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> >
> > The "From:" line of this commit is obviously not correct and does not
> > match this signed-off-by line.
> 
> Sorry, does it mean the "(Google)" part should be present in the From:
> line as well?

A valid email address should be in the "From:" line.

> > Also, as you are from google, just use your google.com email address
> > please.
> 
> Unfortunately Pimyn cannot send emails outside the @google.com domain.

Google has well-known facilities and abilities to handle this, please
use them and do not hide behind gmail accounts.

thanks,

greg k-h