lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zv/0DVQNEsJPoyCR@hu-bjorande-lv.qualcomm.com>
Date: Fri, 4 Oct 2024 06:56:29 -0700
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>,
        Om Prakash Singh
	<quic_omprsing@...cinc.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Gaurav Kashyap <quic_gaurkash@...cinc.com>
Subject: Re: [PATCH v7 0/2] arm64: dts: qcom: extend the register range for
 ICE on sm8[56]50

On Tue, Oct 01, 2024 at 10:35:29AM +0200, Bartosz Golaszewski wrote:
> The following changes extend the register range for ICE IPs on sm8550
> and sm8650 in order to cover the registers used for wrapped key support
> on these platforms.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Changes in v7:
> - bring the ICE register range up to its full size of 0x18000
> - Link to v6: https://lore.kernel.org/r/20240906-wrapped-keys-dts-v6-0-3f0287cf167e@linaro.org
> 
> Changes in v6:
> - split out the DT changes into a separate series

Bartosz, this strategy of "let's split things such that the maintainers
can't see the full picture" is just BS. It needs to stop.

Now you will argue that these patches stands on their own, and that
might be a valid case, but the argumentation you're making in the commit
message clearly ties them to the code changes you're making somewhere
else.

Regards,
Bjorn

> - remove the new DT property from the series
> - rework commit messages
> Link to v5: https://lore.kernel.org/lkml/20240617005825.1443206-1-quic_gaurkash@quicinc.com/
> 
> ---
> Bartosz Golaszewski (2):
>       arm64: dts: qcom: sm8650: extend the register range for UFS ICE
>       arm64: dts: qcom: sm8550: extend the register range for UFS ICE
> 
>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 ++-
>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> ---
> base-commit: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c
> change-id: 20240906-wrapped-keys-dts-b733dac51d01
> 
> Best regards,
> -- 
> Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ