linux-kernel - Re: [PATCH] fbdev: clps711x-fb: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <713a42f1-83d0-4d20-96f0-db9815313205@suse.de>
Date: Fri, 4 Oct 2024 16:02:41 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Qianqiang Liu <qianqiang.liu@....com>, deller@....de
Cc: linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: clps711x-fb: Remove dead code

Hi

Am 04.10.24 um 03:43 schrieb Qianqiang Liu:
> The code can never be reached: unregister_framebuffer(info);
>
> Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/video/fbdev/clps711x-fb.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 9e3df1df5ac4..b57134bc63e7 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -332,8 +332,6 @@ static int clps711x_fb_probe(struct platform_device *pdev)
>   
>   	return 0;
>   
> -	unregister_framebuffer(info);
> -

This used to be code for error rollback, but is now unused. Thanks for 
fixing the issue.

Best regards
Thomas

>   out_fb_dealloc_cmap:
>   	regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0);
>   	fb_dealloc_cmap(&info->cmap);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)