linux-kernel - Re: [PATCH net-next] net: macb: Adding support for Jumbo Frames up to 10240 Bytes in SAMA5D2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cba974d-492e-49f0-8d43-1a75672861d0@microchip.com>
Date: Fri, 4 Oct 2024 16:19:15 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Aleksander Jan Bajkowski <olek2@...pl>, <claudiu.beznea@...on.dev>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, linux-arm-kernel
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next] net: macb: Adding support for Jumbo Frames up to
 10240 Bytes in SAMA5D2

On 03/10/2024 at 19:19, Aleksander Jan Bajkowski wrote:
> As per the SAMA5D2 device specification it supports Jumbo frames.
> But the suggested flag and length of bytes it supports was not updated
> in this driver config_structure.
> The maximum jumbo frames the device supports:
> 10240 bytes as per the device spec.
> 
> While changing the MTU value greater than 1500, it threw error:
> sudo ifconfig eth1 mtu 9000
> SIOCSIFMTU: Invalid argument
> 
> Add this support to driver so that it works as expected and designed.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>

Looks good indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index f06babec04a0..9fda16557509 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4841,10 +4841,11 @@ static const struct macb_config pc302gem_config = {
>   };
> 
>   static const struct macb_config sama5d2_config = {
> -       .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII,
> +       .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO,
>          .dma_burst_length = 16,
>          .clk_init = macb_clk_init,
>          .init = macb_init,
> +       .jumbo_max_len = 10240,
>          .usrio = &macb_default_usrio,
>   };
> 
> --
> 2.39.5
>