[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241004073311.223efca4@kernel.org>
Date: Fri, 4 Oct 2024 07:33:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Veerasenareddy Burru <vburru@...vell.com>, Sathesh Edara
<sedara@...vell.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Abhijit Ayarekar
<aayarekar@...vell.com>, Satananda Burla <sburla@...vell.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<lvc-project@...uxtesting.org>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net v3] octeon_ep: Add SKB allocation failures handling
in __octep_oq_process_rx()
On Mon, 30 Sep 2024 08:33:28 +0300 Aleksandr Mishin wrote:
> build_skb() returns NULL in case of a memory allocation failure so handle
> it inside __octep_oq_process_rx() to avoid NULL pointer dereference.
>
> __octep_oq_process_rx() is called during NAPI polling by the driver. If
> skb allocation fails, keep on pulling packets out of the Rx DMA queue: we
> shouldn't break the polling immediately and thus falsely indicate to the
> octep_napi_poll() that the Rx pressure is going down. As there is no
> associated skb in this case, don't process the packets and don't push them
> up the network stack - they are skipped.
>
> The common code with skb and some index manipulations is extracted to make
> the fix more readable and avoid code duplication. Also helper function is
> implemented to unmmap/flush all the fragment buffers used by the dropped
> packet. 'alloc_failures' counter is incremented to mark the skb allocation
> error in driver statistics.
You're doing multiple things here, please split this patch up.
--
pw-bot: cr
Powered by blists - more mailing lists