linux-kernel - Re: [PATCH] include: linux: Fix flex array member not at the end in bpf_empty_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <674d86d6-4073-4630-b8b1-fe73ab7e995e@embeddedor.com>
Date: Thu, 3 Oct 2024 19:54:22 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Christian Brauner <brauner@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include: linux: Fix flex array member not at the end in
 bpf_empty_prog_array

On 30/09/24 12:16, Philipp Hortmann wrote:
> Struct bpf_prog_array has a flex array member at the end and needs
> therefore to be last in struct bpf_empty_prog_array.
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>

Acked-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks!
--
Gustavo

> ---
>   include/linux/bpf.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index 19d8ca8ac960..1ce319045048 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -2018,8 +2018,8 @@ struct bpf_prog_array {
>   };
>   
>   struct bpf_empty_prog_array {
> -	struct bpf_prog_array hdr;
>   	struct bpf_prog *null_prog;
> +	struct bpf_prog_array hdr;
>   };
>   
>   /* to avoid allocating empty bpf_prog_array for cgroups that