linux-kernel - Re: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac4b5546-366b-437a-a05b-52a53c3bd8a8@lunn.ch>
Date: Fri, 4 Oct 2024 16:50:09 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Kiran Kumar C.S.K" <quic_kkumarcs@...cinc.com>
Cc: Bjorn Andersson <quic_bjorande@...cinc.com>, netdev@...r.kernel.org,
	Andy Gross <agross@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Russell King <linux@...linux.org.uk>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Bhupesh Sharma <bhupesh.sharma@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, vsmuthu@....qualcomm.com,
	arastogi@....qualcomm.com, linchen@....qualcomm.com,
	john@...ozen.org, Luo Jie <quic_luoj@...cinc.com>,
	Pavithra R <quic_pavir@...cinc.com>,
	"Suruchi Agarwal (QUIC)" <quic_suruchia@...cinc.com>,
	"Lei Wei (QUIC)" <quic_leiwei@...cinc.com>
Subject: Re: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet

> The only compile-time dependency from PCS driver to NSS CC driver is
> with the example section in PCS driver's dtbindings file. The PCS DTS
> node example definitions include a header file exported by the NSS CC
> driver, to access certain macros for referring to the MII Rx/Tx clocks.

> So, although there is no dependency in the driver code, a successful
> dtbindings check will require the NSS CC driver to be available.

You are doing something wrong. A clock is just a phandle. The
dtbindings check does not care where the phandle points to, just that
it looks like a phandle. You can hard code the instance to 42 and all
is good.

And this is all just basic getting SoC stuff merged, nothing
special. So why do you not know this? Have you not been subscribed to
arm-soc for the last six months and watched other drivers get merged?
I also really hope you have been on the netdev list for the last few
months and have watched other pcs and ethernet drivers get merged.

	Andrew