linux-kernel - Re: [PATCH] ceph: fix cap ref leak via netfs init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3822584.1728056095@warthog.procyon.org.uk>
Date: Fri, 04 Oct 2024 16:34:55 +0100
From: David Howells <dhowells@...hat.com>
To: Ilya Dryomov <idryomov@...il.com>
Cc: dhowells@...hat.com, Patrick Donnelly <batrick@...bytes.com>,
    Xiubo Li <xiubli@...hat.com>, Patrick Donnelly <pdonnell@...hat.com>,
    stable@...r.kernel.org, ceph-devel@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: fix cap ref leak via netfs init_request

Ilya Dryomov <idryomov@...il.com> wrote:

> The actual problem is that netfs_alloc_request() just frees rreq if
> init_request() callout fails and ceph_netfs_free_request() is never
> called, right?

I could make it call ->free_request() in the case that ->init_request()
returns an error, though I'd prefer that the cleanup be done in
->init_request() rather than passing a partially set-up state to
->free_request().

David