linux-kernel - Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8fb4f241b2d248ca4c2c57b98588e1be0642b76.camel@mediatek.com>
Date: Sat, 5 Oct 2024 10:02:59 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: Bibby Hsieh (謝濟遠) <Bibby.Hsieh@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "djkurtz@...omium.org"
	<djkurtz@...omium.org>, Shawn Sung (宋孝謙)
	<Shawn.Sung@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	CK Hu (胡俊光) <ck.hu@...iatek.com>,
	"yassine.oudjana@...il.com" <yassine.oudjana@...il.com>, "airlied@...il.com"
	<airlied@...il.com>, "me@...mthiede.com" <me@...mthiede.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "littlecvr@...omium.org"
	<littlecvr@...omium.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: YT Shen (沈岳霆) <Yt.Shen@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > @@ -102,12 +102,9 @@ static inline bool is_10bit_rgb(u32 fmt)
> >   }
> > 
> >   static const u32 mt8173_formats[] = {
> > -       DRM_FORMAT_XRGB8888,
> >          DRM_FORMAT_ARGB8888,
> > -       DRM_FORMAT_BGRX8888,
> >          DRM_FORMAT_BGRA8888,
> >          DRM_FORMAT_ABGR8888,
> > -       DRM_FORMAT_XBGR8888,
> >          DRM_FORMAT_RGB888,
> >          DRM_FORMAT_BGR888,
> >          DRM_FORMAT_RGB565,
> 
> This is what I get on MT6735:
> 
> [    1.729467] mediatek-drm mediatek-drm.1.auto: [drm] bpp/depth
> value 
> of 32/24 not supported
> [    1.737777] mediatek-drm mediatek-drm.1.auto: [drm] No compatible 
> format found
> [    1.745943] mediatek-drm mediatek-drm.1.auto: [drm] *ERROR* 
> fbdev-dma: Failed to setup generic emulation (ret=-22)
> 

Hi Adam, Yassine,

Please try the patches below and check if they can fix the downgrade
issue:
[1] Fix degradation problem of alpha blending series
- 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=893634
[2] drm/mediatek: Fix XRGB format breakage for blend_modes unsupported
SoCs
- 
https://patchwork.kernel.org/project/linux-mediatek/patch/20241005095234.12925-1-jason-jh.lin@mediatek.com/

Regards,
Jason-JH.Lin

> > 
> > Regards,
> > Jason-JH.Lin
> > 
> >>
> >> - Adam Thiede
>