linux-kernel - [PATCH v3] media: rj54n1cb0c: possible integer overflow fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241005115859.13273-1-m.lobanov@rosalinux.ru>
Date: Sat,  5 Oct 2024 07:58:57 -0400
From: Mikhail Lobanov <m.lobanov@...alinux.ru>
To: Jacopo Mondi <jacopo@...ndi.org>
Cc: Mikhail Lobanov <m.lobanov@...alinux.ru>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org,
	Aleksandr Burakov <a.burakov@...alinux.ru>,
	Sergey Shtylyov <s.shtylyov@....ru>
Subject: [PATCH v3] media: rj54n1cb0c: possible integer overflow fix

An integer overflow may occur due to arithmetic operation
(multiplication) between value '314572800' and variable 'resize',
where the value comes from '12 * RJ54N1_MAX_WIDTH * (1 << 14)'
and when 'resize' is equal to 16319.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a6b5f2008a3d ("V4L/DVB (13661): rj54n1cb0c: Add cropping, auto white balance, restrict sizes, add platform data")
Signed-off-by: Aleksandr Burakov <a.burakov@...alinux.ru>
Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>
Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
---
v1->v2: updated multiplication operation to use shorthand assignment for improved code readability
link to v1: https://lore.kernel.org/lkml/20240917140454.7880-1-a.burakov@rosalinux.ru/
v2->v3: the subsystem prefix has been updated to 'media: rj54n1cb0c:'.
link to v2: https://lore.kernel.org/lkml/20241004121924.27174-1-m.lobanov@rosalinux.ru/
 drivers/media/i2c/rj54n1cb0c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
index a59db10153cd..a612ec1e7157 100644
--- a/drivers/media/i2c/rj54n1cb0c.c
+++ b/drivers/media/i2c/rj54n1cb0c.c
@@ -776,8 +776,8 @@ static int rj54n1_sensor_scale(struct v4l2_subdev *sd, s32 *in_w, s32 *in_h,
 	}
 
 	/* Antiflicker */
-	peak = 12 * RJ54N1_MAX_WIDTH * (1 << 14) * resize / rj54n1->tgclk_mhz /
-		10000;
+	peak = 12 * RJ54N1_MAX_WIDTH * resize / rj54n1->tgclk_mhz / 10000;
+	peak *= 1 << 14;
 	peak_50 = peak / 6;
 	peak_60 = peak / 5;
 
-- 
2.25.1