linux-kernel - Re: [PATCH v2] sched/psi: fix memory barrier without comment warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3f10804c9b793b90513301a08bdfb406959b6f8.camel@perches.com>
Date: Sat, 05 Oct 2024 06:28:54 -0700
From: Joe Perches <joe@...ches.com>
To: Pintu Kumar <quic_pintu@...cinc.com>, hannes@...xchg.org,
 surenb@...gle.com,  peterz@...radead.org, mingo@...hat.com,
 juri.lelli@...hat.com,  vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org,  bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com,  linux-kernel@...r.kernel.org
Cc: skhan@...uxfoundation.org, pintu.ping@...il.com
Subject: Re: [PATCH v2] sched/psi: fix memory barrier without comment
 warnings

On Sat, 2024-10-05 at 18:46 +0530, Pintu Kumar wrote:
> These warnings were reported by checkpatch.
> Fix them with minor changes.
> No functional changes.
> 
> WARNING: memory barrier without comment
> +       t = smp_load_acquire(trigger_ptr);
> 
> WARNING: memory barrier without comment
> +       smp_store_release(&seq->private, new);
> 
> Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
> Reviewed-by: Joe Perches <joe@...ches.com>

Please do not add signatures not given to you.