linux-kernel - Re: [PATCH] bpf, lsm: Remove bpf_lsm_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwE_veRD7f2ir6mS@krava>
Date: Sat, 5 Oct 2024 15:45:23 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: KP Singh <kpsingh@...nel.org>,
	Matt Bobrowski <mattbobrowski@...gle.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
	Casey Schaufler <casey@...aufler-ca.com>,
	Paul Moore <paul@...l-moore.com>,
	John Johansen <john.johansen@...onical.com>, bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook

On Sat, Oct 05, 2024 at 02:06:28AM +0200, Thomas Weißschuh wrote:
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
> 
> Avoid warnings during the build:
>   BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free

nice, I was wondering about that, lgtm

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> 
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> I don't know much about LSMs, so please disregard if this is wrong.
> ---
>  kernel/bpf/bpf_lsm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
> index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
> --- a/kernel/bpf/bpf_lsm.c
> +++ b/kernel/bpf/bpf_lsm.c
> @@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
>  BTF_ID(func, bpf_lsm_path_chown)
>  #endif /* CONFIG_SECURITY_PATH */
>  
> -#ifdef CONFIG_KEYS
> -BTF_ID(func, bpf_lsm_key_free)
> -#endif /* CONFIG_KEYS */
> -
>  BTF_ID(func, bpf_lsm_mmap_file)
>  BTF_ID(func, bpf_lsm_netlink_send)
>  BTF_ID(func, bpf_lsm_path_notify)
> 
> ---
> base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
> change-id: 20241005-lsm-key_free-b47445ee523d
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@...ssschuh.net>
>