linux-kernel - Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87setapq4s.fsf@trenco.lwn.net>
Date: Sat, 05 Oct 2024 08:42:59 -0600
From: Jonathan Corbet <corbet@....net>
To: Kees Cook <kees@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Nick
 Desaulniers <ndesaulniers@...gle.com>, Rong Xu <xur@...gle.com>
Cc: Han Shen <shenhan@...gle.com>, Sriraman Tallam <tmsriram@...gle.com>,
 David Li <davidxl@...gle.com>, Krzysztof Pszeniczny
 <kpszeniczny@...gle.com>, Alice Ryhl <aliceryhl@...gle.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, Bill Wendling
 <morbo@...gle.com>, Borislav Petkov <bp@...en8.de>, Breno Leitao
 <leitao@...ian.org>, Brian Gerst <brgerst@...il.com>, Dave Hansen
 <dave.hansen@...ux.intel.com>, Heiko Carstens <hca@...ux.ibm.com>, "H.
 Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>, Jann Horn
 <jannh@...gle.com>, Josh Poimboeuf <jpoimboe@...nel.org>, Juergen Gross
 <jgross@...e.com>, Justin Stitt <justinstitt@...gle.com>,
 linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 llvm@...ts.linux.dev, Masahiro Yamada <masahiroy@...nel.org>, "Mike
 Rapoport (IBM)" <rppt@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nicolas Schier <nicolas@...sle.eu>, "Paul E. McKenney"
 <paulmck@...nel.org>, Samuel Holland <samuel.holland@...ive.com>, Thomas
 Gleixner <tglx@...utronix.de>, Wei Yang <richard.weiyang@...il.com>,
 workflows@...r.kernel.org, x86@...nel.org, "Xin Li (Intel)"
 <xin@...or.com>, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

Kees Cook <kees@...nel.org> writes:

> The tradition in kernel .rst is to do this with the trailing "::", e.g.:
>
> +Configure the kernel with::
> +
> +     CONFIG_AUTOFDO_CLANG=y
>
> This loses the language-specific highlighting when rendered. Perhaps the
> "::" extension can be further extended?
>
> +Configure the kernel with::(make)
> +
> +     CONFIG_AUTOFDO_CLANG=y
>
> Then we could avoid the extra 2 lines but still gain the rendered language
> highlights?

The :: notation is standard Sphinx, not an extension we have done.  So
the proposed syntax would have to be done from the beginning, I'm not
sure how easy or hard that would be, or whether it would be worth it.
But then, I've always seen relatively little value in the highlighting;
others clearly differ.

Thanks,

jon