linux-kernel - Re: [PATCH 1/1] net: phy: marvell: avoid bringing down fibre link when autoneg is bypassed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7f39b47c-30f3-4cab-a9eb-8396598aa9c3@lunn.ch>
Date: Sat, 5 Oct 2024 18:42:56 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Qingtao Cao <qingtao.cao.au@...il.com>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net: phy: marvell: avoid bringing down fibre link
 when autoneg is bypassed

On Sat, Oct 05, 2024 at 07:25:05AM +1000, Qingtao Cao wrote:
> Right, the section about it further states that "... To solve this problem,
> the device implements the autoneg bypass mode for serial interface"
> and about several hundreds of ms if the device receives idles then it
> goes to a new state similar to link up.
> 
> In my v4 change no BMCR is used, but the partner's advertised
> configs (1000BASE-X) is read from the phy status register, using
> existing code in that function and testing still finds its working,
> which makes me believe that the autoneg end once it is bypassed,
> it simply adopts its partner's configuration.

Well, for 1000Base-X, autoneg is not about speed, since that is hard
coded to 1G. Autoneg is about pause and priority for duplex mode.

So play with those settings and see what happens.

	Andrew