linux-kernel - Re: [PATCH 1/3] iio: light: vl6180: Add configurable inter-measurement period support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG=0RqKM8HJ-rV54mCjo1-J6FOsed8zoHSWaVJ1YErSNNZDX1w@mail.gmail.com>
Date: Sat, 5 Oct 2024 22:26:09 +0530
From: Abhash jha <abhashkumarjha123@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, lars@...afoo.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] iio: light: vl6180: Add configurable
 inter-measurement period support

> Hi Abhash,
>
> Sampling frequency must be in Hz and reflect how often the channel
> is sampled (not just the inter measurement period.  So this sounds wrong.
> It is sometimes complex to compute but we have to stick to the documented
> ABI.
Got it. I thought of skipping out the complex computation in the
driver and assumed
the user would give me pre-computed ms values.

Just one thing, Is it better to just use IIO_CHAN_INFO_SAMP_FREQ for
"inter-measurement period"
and get the input in HZ (converting HZ to ms in driver)
Or
Define a custom sysfs attribute like `inter_measurement_period` to get
ms values? for this driver.

Thanks,
Abhash