linux-kernel - Re: [PATCH v2 5/7] dt-bindings: iio: adc: add ad485x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241005180717.345257e4@jic23-huawei>
Date: Sat, 5 Oct 2024 18:07:41 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Nuno Sa
 <nuno.sa@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>, Uwe
 Kleine-König <ukleinek@...nel.org>, Andy Shevchenko
 <andy@...nel.org>, David Lechner <dlechner@...libre.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, João Paulo Gonçalves <joao.goncalves@...adex.com>, Ivan Mikhaylov
 <fr0st61te@...il.com>, Dumitru Ceclan <mitrutzceclan@...il.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>, Marius Cristea
 <marius.cristea@...rochip.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Mike Looijmans
 <mike.looijmans@...ic.nl>, Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
 Dragos Bogdan <dragos.bogdan@...log.com>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v2 5/7] dt-bindings: iio: adc: add ad485x

On Fri, 4 Oct 2024 17:07:54 +0300
Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:

> Add devicetree bindings for ad485x family.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
Hi Antoniu

Trivial stuff inline to add to David's review.

Jonathan

> ---
>  1 file changed, 96 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> new file mode 100644
> index 000000000000..899a65504f12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2024 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad485x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD485X family
> +
> +maintainers:
> +  - Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> +  - Dragos Bogdan <dragos.bogdan@...log.com>
> +  - Antoniu Miclaus <antoniu.miclaus@...log.com>
> +
> +description: |
> +  Analog Devices AD485X family

Give us some more idea of what these are.  Brief paragraph or two is fine giving
some key characteristics of these ADCs.  Whilst we know they are ADCs from
the path, maybe good to mention that :)


> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4858.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4857.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4856.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4855.pdf
Numeric order probably better than the reverse.

> +
> +$ref: /schemas/spi/spi-peripheral-props.yaml#