linux-kernel - Re: [PATCH 04/13] iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241005184018.6b06e850@jic23-huawei>
Date: Sat, 5 Oct 2024 18:40:18 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Matti Vaittinen
 <mazziesaccount@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, David Lechner <dlechner@...libre.com>,
 Nuno Sa <nuno.sa@...log.com>, Dan Murphy <dmurphy@...com>, Sean Nyekjaer
 <sean@...nix.com>, Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mihail Chindris <mihail.chindris@...log.com>, Alexandru Ardelean
 <ardeleanalex@...il.com>, Gustavo Silva <gustavograzs@...il.com>, Shoji
 Keita <awaittrot@...k.jp>, Andrey Skvortsov <andrej.skvortzov@...il.com>,
 Dalton Durst <dalton@...orts.com>, Icenowy Zheng <icenowy@...c.io>, Andreas
 Klinger <ak@...klinger.de>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Ondrej Jirman
 <megi@....cz>
Subject: Re: [PATCH 04/13] iio: adc: ti-ads8688: add missing select
 IIO_(TRIGGERED_)BUFFER in Kconfig

On Thu, 03 Oct 2024 23:04:50 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> This driver makes use of triggered buffers, but does not select the
> required modules.
> 
> Fixes: 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support")
> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
Fixes tag must be part of the tag block.

Also this one looks to be a false positive. The driver includes
buffer.h but doesn't actually have buffered support.

> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/iio/adc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 45872a4e2acf..e6be1f1ec79f 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1483,6 +1483,8 @@ config TI_ADS8344
>  config TI_ADS8688
>  	tristate "Texas Instruments ADS8688"
>  	depends on SPI
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  If you say yes here you get support for Texas Instruments ADS8684 and
>  	  and ADS8688 ADC chips
>