linux-kernel - Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241005190147.084dd468@jic23-huawei>
Date: Sat, 5 Oct 2024 19:01:47 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Matti Vaittinen
 <mazziesaccount@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, David Lechner <dlechner@...libre.com>,
 Nuno Sa <nuno.sa@...log.com>, Dan Murphy <dmurphy@...com>, Sean Nyekjaer
 <sean@...nix.com>, Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mihail Chindris <mihail.chindris@...log.com>, Alexandru Ardelean
 <ardeleanalex@...il.com>, Gustavo Silva <gustavograzs@...il.com>, Shoji
 Keita <awaittrot@...k.jp>, Andrey Skvortsov <andrej.skvortzov@...il.com>,
 Dalton Durst <dalton@...orts.com>, Icenowy Zheng <icenowy@...c.io>, Andreas
 Klinger <ak@...klinger.de>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Ondrej Jirman
 <megi@....cz>
Subject: Re: [PATCH 12/13] iio: pressure: bu1390: add missing select
 IIO_(TRIGGERED_)BUFFER in Kconfig

On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> This driver makes use of triggered buffers, but does not select the
> required modules.
> 
> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
> 
> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
patch description to refer to the bm1390 which seems to be the right
name and add a note on this as it looks suspect otherwise.

> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/iio/pressure/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index df65438c771e..d2cb8c871f6a 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -19,6 +19,9 @@ config ABP060MG
>  config ROHM_BM1390
>  	tristate "ROHM BM1390GLV-Z pressure sensor driver"
>  	depends on I2C
> +	select REGMAP_I2C
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
>  	  can measure pressures ranging from 300 hPa to 1300 hPa with
>