linux-kernel - Re: [PATCH v3 02/10] dt-bindings: iio: adc: ad7606: Remove spi-cpha from required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172815406221.521472.1043315949208476695.robh@kernel.org>
Date: Sat, 5 Oct 2024 13:47:42 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Guillaume Stols <gstols@...libre.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Conor Dooley <conor+dt@...nel.org>, linux-pwm@...r.kernel.org,
	Lars-Peter Clausen <lars@...afoo.de>, linux-doc@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-iio@...r.kernel.org,
	aardelean@...libre.com, linux-kernel@...r.kernel.org,
	Uwe Kleine-König <ukleinek@...nel.org>,
	dlechner@...libre.com, devicetree@...r.kernel.org,
	linux-fbdev@...r.kernel.org, Jonathan Corbet <corbet@....net>,
	Jonathan Cameron <jic23@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Hennerich <michael.hennerich@...log.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v3 02/10] dt-bindings: iio: adc: ad7606: Remove spi-cpha
 from required


On Fri, 04 Oct 2024 21:48:36 +0000, Guillaume Stols wrote:
> The documentation is erroneously stating that spi-cpha is required, and
> the example is erroneously setting both spi-cpol and spi-cpha. According
> to the datasheet, only cpol should be set.
> 
> On zedboard for instance, setting the devicetree as in the example will
> simply not work.
> 
> Fixes: 416f882c3b40 ("dt-bindings: iio: adc: Migrate AD7606 documentation to yaml")
> Fixes: 6e33a125df66 ("dt-bindings: iio: adc: Add docs for AD7606 ADC")
> Signed-off-by: Guillaume Stols <gstols@...libre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>