linux-kernel - Re: [PATCH v3 2/4] dt-bindings: mfd: twl: add charger node also for TWL603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241005185721.GA524539-robh@kernel.org>
Date: Sat, 5 Oct 2024 13:57:21 -0500
From: Rob Herring <robh@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Sebastian Reichel <sre@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, tony@...mide.com,
	linux-kernel@...r.kernel.org, khilman@...libre.com,
	linux-pm@...r.kernel.org, linux-omap@...r.kernel.org,
	Lee Jones <lee@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: mfd: twl: add charger node also for
 TWL603x

On Sat, Oct 05, 2024 at 08:05:09AM +0200, Andreas Kemnade wrote:
> Also the TWL603X devices have a charger, so allow to specify it here.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  .../devicetree/bindings/mfd/ti,twl.yaml       | 30 +++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index e94b0fd7af0f8..e772d13adbfdc 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -54,7 +54,7 @@ allOf:
>            $ref: /schemas/iio/adc/ti,twl4030-madc.yaml
>            unevaluatedProperties: false
>  
> -        bci:
> +        charger:
>            type: object
>            $ref: /schemas/power/supply/twl4030-charger.yaml
>            unevaluatedProperties: false
> @@ -105,6 +105,11 @@ allOf:
>              regulator-initial-mode: false
>  
>        properties:
> +        charger:
> +          type: object
> +          properties:
> +            compatible:
> +              const: ti,twl6030-charger
>          gpadc:
>            type: object
>            properties:
> @@ -136,6 +141,13 @@ allOf:
>              regulator-initial-mode: false
>  
>        properties:
> +        charger:
> +          type: object
> +          properties:
> +            compatible:
> +              items:
> +                - const: ti,twl6032-charger
> +                - const: ti,twl6030-charger
>          gpadc:
>            type: object
>            properties:
> @@ -169,6 +181,12 @@ properties:
>    "#clock-cells":
>      const: 1
>  
> +  charger:
> +    type: object
> +    additionalProperties: true
> +    properties:
> +      compatible: true

I think the behavior you're after is:

required:
  - compatible

Because what you have is true when compatible is not present.

With that,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>