linux-kernel - Re: [PATCH] crypto: lib/mpi - Fix an "Uninitialized scalar variable" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwDPLzchPuopuAZK@gondor.apana.org.au>
Date: Sat, 5 Oct 2024 13:31:27 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Qianqiang Liu <qianqiang.liu@....com>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/mpi - Fix an "Uninitialized scalar variable"
 issue

On Sat, Sep 14, 2024 at 08:53:30AM +0800, Qianqiang Liu wrote:
> On Fri, Sep 13, 2024 at 10:07:42PM +0800, Qianqiang Liu wrote:
> > The "err" variable may be returned without an initialized value.
> > 
> > Fixes: 8e3a67f2de87 ("crypto: lib/mpi - Add error checks to extension")
> > Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
> > ---
> >  lib/crypto/mpi/mpi-mul.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/crypto/mpi/mpi-mul.c b/lib/crypto/mpi/mpi-mul.c
> > index 892a246216b9..7e6ff1ce3e9b 100644
> > --- a/lib/crypto/mpi/mpi-mul.c
> > +++ b/lib/crypto/mpi/mpi-mul.c
> > @@ -21,7 +21,7 @@ int mpi_mul(MPI w, MPI u, MPI v)
> >  	int usign, vsign, sign_product;
> >  	int assign_wp = 0;
> >  	mpi_ptr_t tmp_limb = NULL;
> > -	int err;
> > +	int err = 0;
> >  
> >  	if (u->nlimbs < v->nlimbs) {
> >  		/* Swap U and V. */
> > -- 
> > 2.34.1
> 
> Could you please review this patch?

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt