linux-kernel - Re: [PATCH 1/2] crypto: caam: Fix the pointer passed to caam_qi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwDPRsqCIphpCiHP@gondor.apana.org.au>
Date: Sat, 5 Oct 2024 13:31:50 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Horia Geantă <horia.geanta@....com>,
	Pankaj Gupta <pankaj.gupta@....com>,
	Gaurav Jain <gaurav.jain@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrey Smirnov <andrew.smirnov@...il.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 1/2] crypto: caam: Fix the pointer passed to
 caam_qi_shutdown()

On Sun, Sep 15, 2024 at 12:22:12PM +0200, Christophe JAILLET wrote:
> The type of the last parameter given to devm_add_action_or_reset() is
> "struct caam_drv_private *", but in caam_qi_shutdown(), it is casted to
> "struct device *".
> 
> Pass the correct parameter to devm_add_action_or_reset() so that the
> resources are released as expected.
> 
> Fixes: f414de2e2fff ("crypto: caam - use devres to de-initialize QI")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> This patch is speculative review with care.
> ---
>  drivers/crypto/caam/qi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt