linux-kernel - Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf34fd7a-d929-479a-9dea-f6f2ccb67aeb@gmail.com>
Date: Sun, 6 Oct 2024 14:13:29 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Jonathan Cameron <jic23@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 David Lechner <dlechner@...libre.com>, Nuno Sa <nuno.sa@...log.com>,
 Dan Murphy <dmurphy@...com>, Sean Nyekjaer <sean@...nix.com>,
 Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mihail Chindris <mihail.chindris@...log.com>,
 Alexandru Ardelean <ardeleanalex@...il.com>,
 Gustavo Silva <gustavograzs@...il.com>, Shoji Keita <awaittrot@...k.jp>,
 Andrey Skvortsov <andrej.skvortzov@...il.com>,
 Dalton Durst <dalton@...orts.com>, Icenowy Zheng <icenowy@...c.io>,
 Andreas Klinger <ak@...klinger.de>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ondrej Jirman <megi@....cz>
Subject: Re: [PATCH 12/13] iio: pressure: bu1390: add missing select
 IIO_(TRIGGERED_)BUFFER in Kconfig

On 05/10/2024 21:12, Javier Carrasco wrote:
> On 05/10/2024 20:01, Jonathan Cameron wrote:
>> On Thu, 03 Oct 2024 23:04:58 +0200
>> Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:
>>
>>> This driver makes use of triggered buffers, but does not select the
>>> required modules.
>>>
>>> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
>>>
>>> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
>> Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
>> patch description to refer to the bm1390 which seems to be the right
>> name and add a note on this as it looks suspect otherwise.
>>
> Yes, it seems that there was a typo in the title of the patch that added
> the driver (The "Fixes:" is therefore right as it is), and I propagated
> it in the title of this patch as well. But you are right, the driver's
> name is indeed bm1390.

Yep. I typoed the original patch. The correct sensor model is 
BM1390GLV-Z. I got things mixed up in my head as I was simultaneously 
writing drivers the BU270xx light sensors, a BD71851 power management IC 
and BU18xxxx video serializer and deserializer. All the B?<bunch of 
numbers> part IDs got better of me :)

Yours,
	-- Matti