[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0e9479c-0a69-4ffe-aab5-0b5af92df31d@kernel.org>
Date: Sun, 6 Oct 2024 10:39:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sricharan R <quic_srichara@...cinc.com>, andersson@...nel.org,
konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
ulf.hansson@...aro.org, linus.walleij@...aro.org, catalin.marinas@....com,
p.zabel@...gutronix.de, geert+renesas@...der.be,
dmitry.baryshkov@...aro.org, neil.armstrong@...aro.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Cc: quic_varada@...cinc.com
Subject: Re: [PATCH V3 2/7] dt-bindings: clock: Add Qualcomm IPQ5424 GCC
binding
On 04/10/2024 12:23, Sricharan R wrote:
> maintainers:
> - Bjorn Andersson <andersson@...nel.org>
>
> description: |
> Qualcomm global clock control module provides the clocks, resets and power
> - domains on IPQ5332.
> + domains on IPQ5332 and IPQ5424.
>
> - See also:: include/dt-bindings/clock/qcom,gcc-ipq5332.h
> -
> -allOf:
> - - $ref: qcom,gcc.yaml#
> + See also::
s/::/:/
> + include/dt-bindings/clock/qcom,gcc-ipq5332.h
> + include/dt-bindings/clock/qcom,gcc-ipq5424.h
>
> properties:
> compatible:
> - const: qcom,ipq5332-gcc
> + enum:
> + - qcom,ipq5332-gcc
> + - qcom,ipq5424-gcc
>
> clocks:
> + minItems: 5
> items:
> - description: Board XO clock source
> - description: Sleep clock source
> - description: PCIE 2lane PHY pipe clock source
> - description: PCIE 2lane x1 PHY pipe clock source (For second lane)
> + - description: PCIE 2-lane PHY2 pipe clock source
> + - description: PCIE 2-lane PHY3 pipe clock source
> - description: USB PCIE wrapper pipe clock source
Why do you change fifth clock on ipq5332?
Please test your patches - change DTS for ipq5332 and provide PCIE
2-lane PHY2 there.
Best regards,
Krzysztof
Powered by blists - more mailing lists