linux-kernel - Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a014ab86-0767-4ef7-805c-5250e239f4c8@redhat.com>
Date: Sun, 6 Oct 2024 12:45:48 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Crag Wang <crag0715@...il.com>, mario.limonciello@....com,
 Prasanth Ksr <prasanth.ksr@...l.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: crag.wang@...l.com, Crag Wang <crag_wang@...l.com>,
 Dell.Client.Kernel@...l.com, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for
 alienware products

Hi,

On 6-Oct-24 12:43 PM, Hans de Goede wrote:
> Hi,
> 
> On 4-Oct-24 5:27 PM, Crag Wang wrote:
>> Alienware supports firmware-attributes and has its own OEM string.
>>
>> Signed-off-by: Crag Wang <crag_wang@...l.com>
> 
> Thank you for your patch/series, I've applied this patch
> (series) to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Note it will show up in the pdx86 review-hans branch once I've
> pushed my local branch there, which might take a while.
> 
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.

Running checkpatch after applying show:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Crag Wang <crag0715@...il.com>' != 'Signed-off-by: Crag Wang <crag_wang@...l.com>'

I have fixed this by running:

git commit --amend --author="Crag Wang <crag_wang@...l.com>"

So that things match now. Next time please try to use your Dell
email for submitting the patches instead of gmail.

Regards,

Hans