[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b9e1c0ae-5651-418a-9b71-897cd739ed0c@linaro.org>
Date: Sun, 6 Oct 2024 12:21:17 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Jonathan Marek <jonathan@...ek.ca>, linux-arm-msm@...r.kernel.org
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Caleb Connolly <caleb.connolly@...aro.org>,
Guenter Roeck <linux@...ck-us.net>,
"open list:QUALCOMM TYPEC PORT MANAGER DRIVER" <linux-usb@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being
overwritten with RP_DEF
On 05/10/2024 15:41, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
>
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index a747baa297849..c37dede62e12c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
> val = TYPEC_CC_RP_DEF;
> break;
> }
> - val = TYPEC_CC_RP_DEF;
> }
>
> if (misc & CC_ORIENTATION)
Acked-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Powered by blists - more mailing lists