linux-kernel - Re: [PATCH 4/8] iio: frequency: admv4420: add missing select REMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241006142319.5506ca68@jic23-huawei>
Date: Sun, 6 Oct 2024 14:23:19 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, David Lechner
 <dlechner@...libre.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, Cristian Pop
 <cristian.pop@...log.com>, Mircea Caprioru <mircea.caprioru@...log.com>,
 Alexandru Tachici <alexandru.tachici@...log.com>, Marcus Folkesson
 <marcus.folkesson@...il.com>, Fabrice Gasnier <fabrice.gasnier@...com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] iio: frequency: admv4420: add missing select
 REMAP_SPI in Kconfig

On Thu, 3 Oct 2024 21:30:26 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> On 03/10/2024 18:49, Javier Carrasco wrote:
> > This driver makes use of regmap_spi, but does not select the required
> > module.
> > Add the missing 'select REGMAP_SPI'.
> > 
> > Fixes: b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> > ---
> >  drivers/iio/frequency/Kconfig | 17 +++++++++--------
> >  1 file changed, 9 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfig
> > index 89ae09db5ca5..b90e1ac4b342 100644
> > --- a/drivers/iio/frequency/Kconfig
> > +++ b/drivers/iio/frequency/Kconfig
> > @@ -92,14 +92,15 @@ config ADMV1014
> >  	  module will be called admv1014.
> >  
> >  config ADMV4420
> > -       tristate "Analog Devices ADMV4420 K Band Downconverter"
> > -       depends on SPI
> > -       help
> > -         Say yes here to build support for Analog Devices K Band
> > -         Downconverter with integrated Fractional-N PLL and VCO.
> > -
> > -         To compile this driver as a module, choose M here: the
> > -         module will be called admv4420.
> > +	tristate "Analog Devices ADMV4420 K Band Downconverter"
> > +	depends on SPI
> > +	select REGMAP_SPI
> > +	help
> > +	  Say yes here to build support for Analog Devices K Band
> > +	  Downconverter with integrated Fractional-N PLL and VCO.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > +	  module will be called admv4420.
> >  
> >  config ADRF6780
> >          tristate "Analog Devices ADRF6780 Microwave Upconverter"
> >   
> 
> Note that I formatted the entry to use tabs instead of spaces, although
> I forgot to add it to the commit message.
Please split it up.  The fix wants backporting.  Also there are
other white space issues in here that would be good to clean up
(see the entry above).

> 
> Best regards,
> Javier Carrasco
>