[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <c868e394-b1ad-4f30-b27b-c779e3458c42@csgroup.eu>
Date: Sun, 6 Oct 2024 19:37:06 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Christian Zigotzky <chzigotzky@...osoft.de>,
Wu Hoi Pok <wuhoipok@...il.com>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
"open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
open list <linux-kernel@...r.kernel.org>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, "R.T.Dickinson"
<rtd2@...a.co.nz>, mad skateman <madskateman@...il.com>,
hypexed@...oo.com.au, Christian Zigotzky <info@...osoft.de>,
Darren Stevens <darren@...vens-zone.net>
Subject: Re: [PATCH] drm/radeon: add late_register for connector
Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
> On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote:
>> This is a fix patch not tested yet,
>> for a bug I introduce in previous rework of radeon driver.
>> The bug is a null dereference in 'aux.dev', which is the
>> 'device' not registered, resulting in kernel panic. By having
>> 'late_register', the connector should be registered after
>> 'drm_dev_register' automatically.
>>
>> Please help testing thank you.
> Hello Wu Hoi Pok,
>
> Thanks a lot for your patch. Unfortunately there is a new issue after
> patching the RC1. Could you please fix the following issue?
>
> Thanks,
> Christian
>
> ---
>
> Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct 4 08:55:45 CEST
> 2024 ppc64 GNU/Linux
>
> [ 29.167145] systemd[1]: Sent message type=signal sender=n/a
> destination=n/a
> path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice
> interface=org.freedesktop.DBus.Properties member=PropertiesChanged
> cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a
> error-message=n/a
> [ 29.542140] systemd-journald[1301]: Successfully sent stream file
> descriptor to service manager.
> [ 29.561863] BUG: Kernel NULL pointer dereference on read at 0x00000000
> [ 29.567156] Faulting instruction address: 0xc000000000c973c0
> [ 29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
> [ 29.576637] pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
> [ 29.581708] lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
> [ 29.586428] sp: c000000006f978e0
> [ 29.588695] msr: 9000000000009032
> [ 29.590962] dar: 0
> [ 29.591925] dsisr: 40000000
> [ 29.593496] current = 0xc0000000085b1f00
> [ 29.596286] paca = 0xc00000003ffff680 irqmask: 0x03
> irq_happened: 0x01
> [ 29.602119] pid = 1524, comm = Xorg.wrap
> [ 29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp
> (geeko@...ldhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU ld
> (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 SMP
> Fri Oct 4 08:55:45 CEST 2024
> [ 29.623892] enter ? for help
> [ 29.625487] [c000000006f97960] c000000000d28dd8
> .radeon_bo_unref+0x58/0x90
> [ 29.631083] [c000000006f979e0] c000000000e287b0
> .radeon_vm_fini+0x260/0x330
> [ 29.636765] [c000000006f97aa0] c000000000d07c94
> .radeon_driver_postclose_kms+0x1a4/0x1f0
> [ 29.643579] [c000000006f97b30] c000000000c9374c
> .drm_file_free+0x28c/0x300
> [ 29.649174] [c000000006f97be0] c000000000c93900 .drm_release+0x90/0x170
> [ 29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
> [ 29.659495] [c000000006f97d10] c0000000002fe0fc .__se_sys_close+0x4c/0xc0
> [ 29.665004] [c000000006f97d90] c000000000025bac
> .system_call_exception+0x22c/0x260
> [ 29.671295] [c000000006f97e10] c00000000000b554
> system_call_common+0xf4/0x258
> [ 29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
> [ 29.681876] SP (fff4b3d0) is in userspace
> [ 29.684577] 1:mon> <no input ...>
> [ 31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
> [ 31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone X1000
> [ 31.676144] Modules linked in: snd_hda_codec_idt
> snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg
> snd_hda_codec snd_hda_core dm_mod
> [ 31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted
> 6.12.0-rc1-2-powerpc64-smp #1
> [ 31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON Amigaone X1000
> [ 31.701417] NIP: c000000000c973c0 LR: c000000000d28dd8 CTR:
> c000000000d07af0
> [ 31.707250] REGS: c000000006f97640 TRAP: 0300 Not tainted
> (6.12.0-rc1-2-powerpc64-smp)
> [ 31.714128] MSR: 9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR:
> 28002222 XER: 20000000
> [ 31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
> GPR00: c000000000d28dd8 c000000006f978e0
> c00000000207a800 c0000000085f5468
> GPR04: 0000000000000b9b 0000000000000b9a
> 0000000179779000 c0000000086a4b00
> GPR08: 0000000000000000 0000000000000000
> 0000000000000001 0000000000000000
> GPR12: 0000000048002202 c00000003ffff680
> 0000000000000000 0000000000000000
> GPR16: 00000000006e3318 0000000000000001
> 00000000006e289c 0000000000000063
> GPR20: 00000000c04064a0 00000000007f0088
> 00000000fff4c734 00000000007d165c
> GPR24: 00000000007d1668 c000000024b6a220
> c000000003588000 c000000024b6a200
> GPR28: c000000003b3cc00 c000000024b6a248
> c000000002d48820 c0000000085f5468
> [ 31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
> [ 31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
> [ 31.788062] Call Trace:
> [ 31.789199] [c000000006f978e0] [c000000006f97990] 0xc000000006f97990
> (unreliable)
> [ 31.795388] [c000000006f97960] [c000000000d28dd8]
> .radeon_bo_unref+0x58/0x90
> [ 31.801142] [c000000006f979e0] [c000000000e287b0]
> .radeon_vm_fini+0x260/0x330
> [ 31.806982] [c000000006f97aa0] [c000000000d07c94]
> .radeon_driver_postclose_kms+0x1a4/0x1f0
> [ 31.813954] [c000000006f97b30] [c000000000c9374c]
> .drm_file_free+0x28c/0x300
> [ 31.819707] [c000000006f97be0] [c000000000c93900] .drm_release+0x90/0x170
> [ 31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
> [ 31.830342] [c000000006f97d10] [c0000000002fe0fc]
> .__se_sys_close+0x4c/0xc0
> [ 31.836010] [c000000006f97d90] [c000000000025bac]
> .system_call_exception+0x22c/0x260
> [ 31.842460] [c000000006f97e10] [c00000000000b554]
> system_call_common+0xf4/0x258
> [ 31.848476] --- interrupt: c00 at 0x6b2b48
> [ 31.851267] NIP: 00000000006b2b48 LR: 00000000006b2b20 CTR:
> 0000000000000000
> [ 31.857101] REGS: c000000006f97e80 TRAP: 0c00 Not tainted
> (6.12.0-rc1-2-powerpc64-smp)
> [ 31.863978] MSR: 100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI> CR:
> 28002400 XER: 00000000
> [ 31.871235] IRQMASK: 0
> GPR00: 0000000000000006 00000000fff4b3d0
> 00000000f7b7f3a0 0000000000000003
> GPR04: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> GPR08: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> GPR12: 0000000000000000 00000000007efff4
> 0000000000000000 0000000000000000
> GPR16: 00000000006e3318 0000000000000001
> 00000000006e289c 0000000000000063
> GPR20: 00000000c04064a0 00000000007f0088
> 00000000fff4c734 00000000007d165c
> GPR24: 00000000007d1668 00000000fff4b400
> 0000000000000001 0000000000000001
> GPR28: 00000000fff4b46c 0000000000000000
> 00000000007bfff4 0000000000000003
> [ 31.926053] NIP [00000000006b2b48] 0x6b2b48
> [ 31.928930] LR [00000000006b2b20] 0x6b2b20
> [ 31.931720] --- interrupt: c00
> [ 31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6
> fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140
> <e9290000> 7d2a0074 794ad182 0b0a0000
> [ 31.946913] ---[ end trace 0000000000000000 ]---
>
>
That's a NULL pointer dereference in drm_gem_object_free().
Trying to read obj->funcs->free while obj->funcs is NULL.
Christophe
Powered by blists - more mailing lists