linux-kernel - Re: [PATCH v5] pidfd: add ioctl to retrieve pid info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241006173812.GB10213@redhat.com>
Date: Sun, 6 Oct 2024 19:38:13 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: luca.boccassi@...il.com
Cc: linux-kernel@...r.kernel.org, christian@...uner.io
Subject: Re: [PATCH v5] pidfd: add ioctl to retrieve pid info

On 10/06, luca.boccassi@...il.com wrote:
>
> +#ifdef CONFIG_CGROUPS
> +	if (request_mask & PIDFD_INFO_CGROUPID) {

Should we nack other bits in request_mask?

> +		struct cgroup *cgrp = task_css_check(task, pids_cgrp_id, 1)->cgroup;

Well, the last "1" argument just fools CONFIG_PROVE_RCU, right?

It seems you need rcu_read_lock() + task_cgroup(pids_cgrp_id)...

Oleg.