linux-kernel - Re: [PATCH] mm/truncate: reset xa_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOUHufbsHKDWidQwEUViPRw-snCUnn6JVvd1DnNefK6xhmPD5Q@mail.gmail.com>
Date: Sun, 6 Oct 2024 16:03:31 -0600
From: Yu Zhao <yuzhao@...gle.com>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, 
	Matthew Wilcox <willy@...radead.org>, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Meta kernel team <kernel-team@...a.com>
Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration

On Wed, Oct 2, 2024 at 4:52 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
>
> Currently mapping_try_invalidate() and invalidate_inode_pages2_range()
> traverses the xarray in batches and then for each batch, maintains and
> set the flag named xa_has_values if the batch has a shadow entry to
> clear the entries at the end of the iteration. However they forgot to
> reset the flag at the end of the iteration which cause them to always
> try to clear the shadow entries in the subsequent iterations where
> there might not be any shadow entries. Fixing it.
>
> Fixes: 61c663e020d2 ("mm/truncate: batch-clear shadow entries")
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>

Acked-by: Yu Zhao <yuzhao@...gle.com>