[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADxym3aO+KR8wthn9-LK7nOBKH+=+gbWykw-E-sVaaa+Lwpp-w@mail.gmail.com>
Date: Sun, 6 Oct 2024 11:51:40 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: idosch@...dia.com, aleksander.lobakin@...el.com, horms@...nel.org,
davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com,
gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com,
razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason()
helper
On Sat, Oct 5, 2024 at 12:43 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 1 Oct 2024 15:32:16 +0800 Menglong Dong wrote:
> > -static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
> > - bool inner_proto_inherit)
> > +static inline enum skb_drop_reason
> > +skb_vlan_inet_prepare_reason(struct sk_buff *skb, bool inner_proto_inherit)
>
> this only has 5 callers, please convert them to expect a drop
> reason to be returned instead of adding a compatibility wrapper
Okay!
> --
> pw-bot: cr
Powered by blists - more mailing lists