linux-kernel - Re: [PATCH 2/2] pinctrl: th1520: Fix return value for unknown pin error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2be4c920-b4c7-4b7a-ae63-258f2d86df92@web.de>
Date: Sun, 6 Oct 2024 08:09:34 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Drew Fustini <dfustini@...storrent.com>, linux-gpio@...r.kernel.org,
 linux-riscv@...ts.infradead.org, Fu Wei <wefu@...hat.com>,
 Guo Ren <guoren@...nel.org>, Linus Walleij <linus.walleij@...aro.org>
Cc: Drew Fustini <drew@...7.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: th1520: Fix return value for unknown pin
 error

> Fix th1520_pinctrl_dt_node_to_map() to a return value upon an unknown

                                      to return an error code?


> pin error before jumping to free_configs.

…
> +++ b/drivers/pinctrl/pinctrl-th1520.c
> @@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
>  				nmaps = rollback;
>  				dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n",
>  					np, child, pinname);
> +				ret = -EINVAL;
>  				goto free_configs;
>  			}
…

Would you dare to support another jump target for this assignment statement?

Regards,
Markus