linux-kernel - Re: [PATCH 1/2] dt-bindings: mmc: mmc-pwrseq-simple: add support for reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92a27d06-cd37-42ff-ac48-687981d24d41@leica-geosystems.com>
Date: Mon, 7 Oct 2024 15:32:42 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Rob Herring <robh@...nel.org>
CC: "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
	GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>
Subject: Re: [PATCH 1/2] dt-bindings: mmc: mmc-pwrseq-simple: add support for
 reset control

On 05/10/2024 20:26, Rob Herring wrote:
> [Some people who received this message don't often get email from robh@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Fri, Oct 04, 2024 at 02:07:39PM +0200, Catalin Popescu wrote:
>> Add compatible value "mmc-pwrseq-simple-reset" to support reset control
>> instead of gpios. Reset controls being refcounted, they allow to use
>> shared resets or gpios across drivers. Support of reset control is
>> limited to one single reset control.
> Can't you do this without a binding change? Just use reset controls when
> there is only 1 GPIO.

That's a good question. The idea was to keep in place the gpio support 
w/o impacting any platform using pwrseq-simple.

Also, later on when support for a list of reset gpios will be added to 
the reset framework, this would not work anymore...

>
>> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
>> ---
>>   .../bindings/mmc/mmc-pwrseq-simple.yaml       | 21 +++++++++++++++++--
>>   1 file changed, 19 insertions(+), 2 deletions(-)