[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20241007153812.1204605-1-colin.i.king@gmail.com>
Date: Mon, 7 Oct 2024 16:38:12 +0100
From: Colin Ian King <colin.i.king@...il.com>
To: Steve French <sfrench@...ba.org>,
Paulo Alcantara <pc@...guebit.com>,
Ronnie Sahlberg <ronniesahlberg@...il.com>,
Shyam Prasad N <sprasad@...rosoft.com>,
Tom Talpey <tom@...pey.com>,
Bharath SM <bharathsm@...rosoft.com>,
linux-cifs@...r.kernel.org,
samba-technical@...ts.samba.org
Cc: kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH][next] smb: client: remove deadcode check on ret < 0
The variable ret is assigned zero and never changed in function
collect_samle, hence the check for ret < 0 is always false. Fix
this by removing ret and the check on ret since these are redundant.
Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
fs/smb/client/compress.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/smb/client/compress.c b/fs/smb/client/compress.c
index 63b5a55b7a57..766b4de13da7 100644
--- a/fs/smb/client/compress.c
+++ b/fs/smb/client/compress.c
@@ -166,7 +166,6 @@ static int collect_sample(const struct iov_iter *iter, ssize_t max, u8 *sample)
loff_t start = iter->xarray_start + iter->iov_offset;
pgoff_t last, index = start / PAGE_SIZE;
size_t len, off, foff;
- ssize_t ret = 0;
void *p;
int s = 0;
@@ -193,9 +192,6 @@ static int collect_sample(const struct iov_iter *iter, ssize_t max, u8 *sample)
memcpy(&sample[s], p, len2);
kunmap_local(p);
- if (ret < 0)
- return ret;
-
s += len2;
if (len2 < SZ_2K || s >= max - SZ_2K)
--
2.39.5
Powered by blists - more mailing lists