linux-kernel - Re: [PATCH] block: Fix elevator_get_default() to check for null q->tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwN3YvV_j_s0ULhT@infradead.org>
Date: Sun, 6 Oct 2024 22:53:38 -0700
From: Christoph Hellwig <hch@...radead.org>
To: SurajSonawane2415 <surajsonawane0215@...il.com>
Cc: axboe@...nel.dk, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Fix elevator_get_default() to check for null
 q->tag_set

>  static struct elevator_type *elevator_get_default(struct request_queue *q)
>  {
> -	if (q->tag_set && q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)
> -		return NULL;
> +	if (q->tag_set) {

q->tag_set can't be NULL for a blk-mq queue.  So you can just remove
the q->tag_set check here and also in elv_support_iosched.