[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p7lqqhet6ahmvieh5xaws6ugsnasmuw6k4oajkmfcctuhrs4dn@quvrkmyof5ss>
Date: Mon, 7 Oct 2024 07:55:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Wunderlich <linux@...web.de>
Cc: Chaotian Jing <chaotian.jing@...iatek.com>,
Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Wenbin Mei <wenbin.mei@...iatek.com>,
Frank Wunderlich <frank-w@...lic-files.de>, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, daniel@...rotopia.org, john@...ozen.org, eladwf@...il.com,
ansuelsmth@...il.com
Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
On Sun, Oct 06, 2024 at 05:34:45PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
>
> Add binding definitions for mmc on MT7988 SoC.
>
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> ---
> v2:
> - fixed minItems to 4
> ---
> .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index c532ec92d2d9..7380f72ea189 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -21,6 +21,7 @@ properties:
> - mediatek,mt7620-mmc
> - mediatek,mt7622-mmc
> - mediatek,mt7986-mmc
> + - mediatek,mt7988-mmc
> - mediatek,mt8135-mmc
> - mediatek,mt8173-mmc
> - mediatek,mt8183-mmc
> @@ -263,6 +264,29 @@ allOf:
> - const: bus_clk
> - const: sys_cg
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt7988-mmc
> + then:
> + properties:
> + clocks:
> + minItems: 4
Drop
> + items:
> + - description: source clock
> + - description: HCLK which used for host
> + - description: Advanced eXtensible Interface
> + - description: Advanced High-performance Bus clock
> + clock-names:
> + minItems: 3
This is still wrong... anyway, drop.
Best regards,
Krzysztof
Powered by blists - more mailing lists