linux-kernel - Re: [PATCH v2 0/6] Enhance union-find with KUnit tests and optimization improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwQJ_hQENEE7uj0q@slm.duckdns.org>
Date: Mon, 7 Oct 2024 06:19:10 -1000
From: Tejun Heo <tj@...nel.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: xavier_qy@....com, longman@...hat.com, lizefan.x@...edance.com,
	hannes@...xchg.org, mkoutny@...e.com, akpm@...ux-foundation.org,
	jserv@...s.ncku.edu.tw, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org
Subject: Re: [PATCH v2 0/6] Enhance union-find with KUnit tests and
 optimization improvements

Hello,

On Mon, Oct 07, 2024 at 11:28:27PM +0800, Kuan-Wei Chiu wrote:
> This patch series adds KUnit tests for the union-find implementation
> and optimizes the path compression in the uf_find() function to achieve
> a lower tree height and improved efficiency. Additionally, it modifies
> uf_union() to return a boolean value indicating whether a merge
> occurred, enhancing the process of calculating the number of groups in
> the cgroup cpuset.

I'm not necessarily against the patchset but this probably is becoming too
much polishing for something which is only used by cpuset in a pretty cold
path. It probably would be a good idea to concentrate on finding more use
cases.

Thanks.

-- 
tejun